Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

975 improve iphone launch sequence new #1000

Merged
merged 43 commits into from
Oct 10, 2024

Conversation

BPerlakiH
Copy link
Collaborator

@BPerlakiH BPerlakiH commented Oct 6, 2024

Fixes: #975

Re-opening from: #976

What had to be changed:

  • Changed the logo assets
  • Changed the order of the category tabs on iPhone, in order to make the opening animation smooth (from: "opened, categories, downloads, new" to: "categories, new, downloads, opened")
  • In terms of the splash screen, since we cannot localise the message, and it's not recommended by Apple to include any text on it:

Avoid including text on your launch screen, even if your first screen displays text. Because the content in a launch screen doesn’t change, any text you display won’t be localized.

  • For this reason, I removed the text from the splash screen, we do have it on the loading screen though. Another reason, is that the button and text position is calculated on the rendered image size, which is not possible on the splash screen.
  • Slight update is needed on the custom apps side, we need to add the original image width / height, as swiftui is not giving us these values (at least I haven't found a way to do that).
    This extra overhead with the original image size (and any change on the custom app side) can be avoided if we position the buttons (and loading text) relative to the screen height. The only difference will be that the space between the Logo and the buttons (and loading text) will be smaller or larger depending on the screen size.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 76.32653% with 58 lines in your changes missing coverage. Please review.

Project coverage is 39.86%. Comparing base (1f28cbd) to head (43f104e).

Files with missing lines Patch % Lines
App/SplitViewController.swift 10.52% 17 Missing ⚠️
Views/BuildingBlocks/LoadingView.swift 80.45% 17 Missing ⚠️
Views/Welcome.swift 86.07% 11 Missing ⚠️
App/CompactViewController.swift 60.86% 9 Missing ⚠️
Views/Library/Library.swift 66.66% 2 Missing ⚠️
Views/Library/ZimFilesCategories.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
- Coverage   40.00%   39.86%   -0.15%     
==========================================
  Files         114      116       +2     
  Lines        6472     6618     +146     
==========================================
+ Hits         2589     2638      +49     
- Misses       3883     3980      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BPerlakiH
Copy link
Collaborator Author

Previews:

iPhone:

iphone_light.mov
iphone_post_inst_dark.mov

iPad:

ipad_first_inst_light.mov

macOS:

mac_os.mov

@BPerlakiH BPerlakiH requested review from kelson42 and rgaudin October 9, 2024 09:08
@BPerlakiH BPerlakiH marked this pull request as ready for review October 9, 2024 09:09
Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BPerlakiH After a first look, looks good modulo:

  • The logo+buttons block is not centered vertically properly
  • iphone_post_inst_dark.mov has still a spinner where we have said we son't have spinner there

@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Oct 9, 2024

@kelson42 I have updated so that the whole logo + button block is now vertically centered.

ipad.mov
iphone_light.mov
iphone_land_dark.mov

@BPerlakiH BPerlakiH requested a review from kelson42 October 9, 2024 22:21
@kelson42
Copy link
Contributor

@BPerlakiH What about the spinner?

@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Oct 10, 2024

@kelson42 That's seems to be good, the former recording was a post install (2nd time app launch) sequence, as you can see on the new screen recording, first time users won't have the spinner.

@kelson42 kelson42 merged commit 4cffee9 into main Oct 10, 2024
4 checks passed
@kelson42 kelson42 deleted the 975-improve-iphone-launch-sequence-new branch October 10, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve launch sequence
3 participants